Talk:SE250:lab-5:sdal039

From Marks Wiki
Jump to navigation Jump to search

Comment from John Hamer

  • I'm assuming you ran an experiment to determine the sample size. Give details.
  • Nice table of results. A graph would be nicer still.
  • You don't explain how you ranked the hash functions. What is the justification for giving two rankings, one for low and one for typical entropy inputs?
  • buzhash and buzhashn are not best in both cases; Java String Hash comes at the top of one list.
  • a load factor of 0.1 is very low. You give no reason for this choice.

Overall, you have done a nice job of presenting the results and an admirably concise conclusion. I'd like to read about any difficulties you encountered. Some unexpected results deserved more discussion. What does it mean for Java String has to perform well in theory, yet hash every string to the same location? How can that be?