Talk:SE250:lab-5:klod004

Comments from John Hamer

• Very nice summary of the measurements

• Nice table.

• "different set of trials were made" — what trials? You need to explain what you did.

• "keys = 1000, table = 50000." — how did you decide on these values? This gives a severely under-loaded hash table

• The n_keys and table_size parameters have no effect on the ent_test. Your report suggests they do.

• You have not explained the chi-test.

• You may not have noticed that buzhashn does not use the input source — it always hashes consecutive integers. So, there is no "buzhashn low" and "buzhashn high".

You have the start of a good report here; shame you didn't get further.

I'd like you to include more reflections in your report; e.g. why did you decide to ask the lecturer about the sample size? What didn't you understand?

Overall, a reasonable effort.