Talk:SE250:lab-5:sbas046

Comments from John Hamer

• "sample_size = 1000;" — you must justify your choice of sample size. This is important. If you get it wrong, you risk collecting worthless data.

• What is your reasoning behind the ranking of the hash functions? Bear in mind that the rand functions are not hash functions, and were only included for the purposes of comparison.

• There is no "high typical" and "high low"; the random functions ignore the input string.

• Presenting the verbose output is unhelpful. A table (or, better, graph) is more appropriate.

• Task 2: you must give some results, not just pull a conclusion out of thin air!

Good that you give some conclusions, but you have not said enough about how you came to these conclusions. Do you understand the meaning of all the stats tests? If not, then you need to say so. That's one of the reasons for having a reflective essay: you're supposed to say what you understood and what you didn't understand. It helps me to know, and it helps you to know what you don't know and to thing about how you might find out.